Skip to content

Conversation

@glennblock
Copy link
Contributor

@glennblock glennblock commented Feb 16, 2017

Fix for #1213

@daveaglick
Copy link

One suggestion I have would be to consider pulling the FrameworkName from either the current assembly or a known assembly instead of baking it in. That way you won't need to remember to change it if/when running on different frameworks.

See here for an example: https://github.com/Wyamio/Wyam/blob/353f72a84cea7c2747517e3b534fa8d8aaaa5fc2/src/core/Wyam.Configuration/NuGet/PackageInstaller.cs#L42

@glennblock
Copy link
Contributor Author

Right now we only support one, but that is a good point to consider if we end up getting support for .NET Core at some point.

@glennblock
Copy link
Contributor Author

@daveaglick does it make sense for us to upgrade to the NuGet 3 client? Currently we only support .NET 4.5, though we are going to move to require 4.6 soon.

@glennblock
Copy link
Contributor Author

@daveaglick thanks for the link, I will use that approach.

@daveaglick
Copy link

So are you still on the v2 NuGet APIs? If so, I would suggest moving to v3. AFAIK, the v2 APIs aren't getting any more love. There's a lot of breakage though. I'll take a look tomorrow to see what it might take to bump you up.

@glennblock
Copy link
Contributor Author

@daveaglick updated. Works beautifully, thanks!

@glennblock
Copy link
Contributor Author

Allright, based on all MY testing (and the fact that Travis and TC pass) I am going to just go and merge this. I'll ask for forgiveness later if that was a bad idea.

@glennblock glennblock merged commit 76ec57b into scriptcs:dev Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants