-
Notifications
You must be signed in to change notification settings - Fork 369
Fixes #1172 and #1173 #1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1172 and #1173 #1177
Conversation
glennblock
commented
Sep 6, 2016
- Locks Travis mono build version to 4.2.3.
- Fixes cp command.
|
OK so pinning to Mono 4.2.3 seems to have worked. The 2 tests failing are because of the cp command. |
|
doh, my case sensitivity was wrong. |
|
Yay! |
|
@adamralph @ilovezfs pinning indeed fixed it for now. |
|
@glennblock nice work :) |
|
@ilovezfs it won't fix it for brew though as you said because of the mono version. |
|
@ilovezfs based on where all the acceptance tests are failing in the code, it really looks like it is a very specific issue related to how mono is returning the stdout stream. The likelihood is that scriptcs itself will work fine. Do you want me to create for you the brew build.sh file? |
|
@glennblock that would be great. |
|
@ilovezfs just committed build_brew.sh to dev, and master. It doesn't affect our release, so there was no problem just committing to master. |
|
@glennblock awesome 💚 |
|
Thanks for the help!
|
