Pretty Printing #1156
Merged
Pretty Printing #1156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Cool! @filipw this doesn't move to console but it does introduce a Print method on Env which can be called outside the REPL. |
Contributor
|
Let's get a unit of acceptance test |
|
|
||
| public void Print(object o) | ||
| { | ||
| Console.WriteLine(_printers.GetStringFor(o)); |
Contributor
There was a problem hiding this comment.
Shouldn't this be _console?
Contributor
|
Awesome work, thanks! Make sure to add your name to our contributors page! |
Member
|
👍 thanks |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty printing support for ScriptCS in REPL
(some of original changes are squashed in @glennblock commit)
For running scripts without repl you can also use:
There is also an overload for Print< T >(T obj) that allows for Print(derived)
@glennblock and I were also discussing the possibility of extracting a Printers interface (a little odd in a test setup to pass the dependecy in).
As state before this is to open up conversation.