Skip to content

ChocolateyInstall.ps1 should not restore Roslyn packages #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glennblock merged 1 commit into from
Mar 23, 2016
Merged

ChocolateyInstall.ps1 should not restore Roslyn packages #1140

glennblock merged 1 commit into from
Mar 23, 2016

Conversation

@jrusbatch
Copy link
Member

@jrusbatch jrusbatch commented Mar 22, 2016

Previous versions required that Roslyn be restored from NuGet. This is no longer necessary, since we now distribute a more recent release of Roslyn in our package.

Steps to test:

  1. Run build.cmd.
  2. Navigate to artifacts\Release.
  3. Run choco install scriptcs -source .

Scriptcs v0.16.0 should install without error.

@jrusbatch
ChocolateyInstall.ps1 should not restore Roslyn
cfdfa6f 
Previous versions required that Roslyn be restored from NuGet. This is
no longer necessary, since we now distribute a more recent release of
Roslyn in our package.
@glennblock
Copy link
Contributor

glennblock commented Mar 23, 2016

Checking now

@glennblock glennblock merged commit f2506d5 into scriptcs:dev Mar 23, 2016
@glennblock
Copy link
Contributor

glennblock commented Mar 23, 2016

Verified, thanks @jrusbatch!

@adamralph
Copy link
Contributor

adamralph commented Mar 26, 2016

Are we complying with the license for https://www.nuget.org/packages/Roslyn.Compilers.CSharp by distributing it with scriptcs?

@glennblock
Copy link
Contributor

glennblock commented Mar 26, 2016

The new Roslyn bits are OSS . We can distribute it.
On Sat, Mar 26, 2016 at 9:04 AM Adam Ralph notifications@github.com wrote:

Are we complying with the license for
https://www.nuget.org/packages/Roslyn.Compilers.CSharp by distributing it
with scriptcs?

—
You are receiving this because you modified the open/close state.

Reply to this email directly or view it on GitHub
#1140 (comment)

@adamralph
Copy link
Contributor

adamralph commented Mar 26, 2016

OK, so this is fine for the dev branch.

Our master branch has been distributing the old Roslyn bits for some time now (with the redundant restore in the chocolatey script) but that is a separate issue.

@glennblock
Copy link
Contributor

glennblock commented Mar 26, 2016

Really? I thought those are the newer bits.
On Sat, Mar 26, 2016 at 9:35 AM Adam Ralph notifications@github.com wrote:

OK, so this is fine for the dev branch.

Our master branch has been distributing the old Roslyn bits for some time
now (with the redundant restore in the chocolatey script) but that is a
separate issue.

—
You are receiving this because you modified the open/close state.

Reply to this email directly or view it on GitHub
#1140 (comment)

@adamralph
Copy link
Contributor

adamralph commented Mar 26, 2016

We haven't yet released a version using anything newer than the old CTP with the restrictive license.

@jrusbatch jrusbatch deleted the chocolatey-script branch March 26, 2016 17:15
@glennblock glennblock added this to the v0.16 milestone Apr 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.16

Development

Successfully merging this pull request may close these issues.

3 participants

@jrusbatch @glennblock @adamralph