Renames ScriptCs.CSharp to ScriptCs.Engine.Roslyn #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common/CommonVersionInfo.cs
Outdated
| @@ -1,9 +1,18 @@ | |||
| //------------------------------------------------------------------------------ | |||
Member
There was a problem hiding this comment.
this file should be reverted, the original even says:
Do not manually edit this file
Member
|
not sure what to do with |
Contributor
Author
|
Hmm I think my changes got overwritten when I pulled Dev. I had renamed the
|
Contributor
Author
|
@filipw we should remove VB probably. Maybe you should release it as a sep module? |
Member
|
yeah let's remove it, can you please update this branch to revert the module rename |
Contributor
Author
|
@filipw thanks for the feedback and for catching the issues. All issues have been fixed and I removed the VB module. |
filipw
added a commit
that referenced
this pull request
Feb 28, 2016
Renames ScriptCs.CSharp to ScriptCs.Engine.Roslyn
Member
|
👍 |
Contributor
Author
This was referenced Feb 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1133