Provide editing capabilities using Mono.Terminal.GetLine. #1119
Conversation
This provides command line editing, history, and reverse history search using the Emacs keybindings, similar to bash.
… for *nix, and fixing several unit tests
There was a problem hiding this comment.
why is there prompt if it's not being used?
There was a problem hiding this comment.
It is used.
On Mon, Nov 9, 2015 at 7:10 AM Filip W notifications@github.com wrote:
In src/ScriptCs.Hosting/FileConsole.cs
#1119 (comment):@@ -35,9 +35,9 @@ public void WriteLine(string value)
this.AppendLine(value);
}
public string ReadLine()public string ReadLine(string prompt)why is there prompt if it's not being used?
—
Reply to this email directly or view it on GitHub
https://github.com/scriptcs/scriptcs/pull/1119/files#r44284665.
There was a problem hiding this comment.
the whole method is
public string ReadLine(string prompt)
{
var line = _innerConsole.ReadLine("");
this.AppendLine(line);
return line;
}
There was a problem hiding this comment.
It's just not used in the FileConsole.
There was a problem hiding this comment.
Correct, it is part of the general interface
On Mon, Nov 9, 2015 at 7:51 AM Kristian Hellang notifications@github.com
wrote:
In src/ScriptCs.Hosting/FileConsole.cs
#1119 (comment):@@ -35,9 +35,9 @@ public void WriteLine(string value)
this.AppendLine(value);
}
public string ReadLine()public string ReadLine(string prompt)It's just not used in the FileConsole.
—
Reply to this email directly or view it on GitHub
https://github.com/scriptcs/scriptcs/pull/1119/files#r44290238.
|
ok let's merge this, if something is still discovered to be wrong please make a corrective PR I wanna play with this |
adamralph
changed the title
5 participants
Adds @migueldeicaza's PR and some cleanup / fixing of tests.