-
Notifications
You must be signed in to change notification settings - Fork 370
Provide editing capabilities using Mono.Terminal.GetLine. #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The line editor also contains support for code completion, to hook it up, you should follow the steps that are done in this file: |
This provides command line editing, history, and reverse history search using the Emacs keybindings, similar to bash.
|
Awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can avoid this breaking change. I'll have a play...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. The code we had before should work / we don't need prompt to be a param.
|
@migueldeicaza, thank you for this! We're going to close and pull your branch and do a little cleanup and then we'll push your commits as well as some tweaks. |
|
We don't have to close. We can add clean up commit(s), send a new PR, merge it and then this one will show as merged too. |
|
I got this folks, I'll clean it up and the unit tests. |
|
Let's add Miguel to the contributors list! Thank you @migueldeicaza!
|
|
Subset of #1119 |
This provides command line editing, history, and reverse history
search using the Emacs keybindings, similar to bash.