Skip to content

Conversation

@migueldeicaza
Copy link
Contributor

This provides command line editing, history, and reverse history
search using the Emacs keybindings, similar to bash.

@migueldeicaza
Copy link
Contributor Author

The line editor also contains support for code completion, to hook it up, you should follow the steps that are done in this file:

https://github.com/mono/mono/tree/master/mcs/tools/csharp

This provides command line editing, history, and reverse history
search using the Emacs keybindings, similar to bash.
@glennblock
Copy link
Contributor

Awesome!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can avoid this breaking change. I'll have a play...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. The code we had before should work / we don't need prompt to be a param.

@glennblock
Copy link
Contributor

@migueldeicaza, thank you for this! We're going to close and pull your branch and do a little cleanup and then we'll push your commits as well as some tweaks.

@glennblock glennblock closed this Nov 5, 2015
@adamralph
Copy link
Contributor

We don't have to close. We can add clean up commit(s), send a new PR, merge it and then this one will show as merged too.

@glennblock glennblock reopened this Nov 5, 2015
@glennblock
Copy link
Contributor

I got this folks, I'll clean it up and the unit tests.

@glennblock glennblock self-assigned this Nov 8, 2015
@filipw filipw merged commit e84a769 into scriptcs:dev Nov 14, 2015
@glennblock
Copy link
Contributor

Let's add Miguel to the contributors list! Thank you @migueldeicaza!
On Sat, Nov 14, 2015 at 6:13 AM Filip W notifications@github.com wrote:

Merged #1118 #1118.


Reply to this email directly or view it on GitHub
#1118 (comment).

@adamralph
Copy link
Contributor

Subset of #1119

@glennblock glennblock added this to the v0.16 milestone Apr 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants