Added a hotfix which deletes temporary folders created by NuGet #1093
Conversation
|
Thanks! |
|
Ah - just saw the build fail because of a bug I introduced. Going to fix now. Please stay with me ;) |
There was a problem hiding this comment.
Whilst acknowledging that this is always going to be a hack, my first question is whether this is the right place to put it.
This method retreives a list of the DLLs contained within the package which are compatible with the specified framework. Is this the right place to add the side effect of removing the folders from the temp folder? If the preceding (existing) lines in the method have the side effect of creating them, then it is the right place. If not, I think it may be worth searching for a better place to put this.
There was a problem hiding this comment.
Yes, they do. Line 61 (var dlls = _package.GetLibFiles().Where(i => i.EffectivePath.EndsWith(Dll) || i.EffectivePath.EndsWith(Exe));) creates the temporary files. After this method, you have no access to the underlying SourcePath property. Therefore it has to be there (unfortunately).
There was a problem hiding this comment.
Wow, that is ugly! 😲
In that case I agree, this is the right place to put this hack.
There was a problem hiding this comment.
Indeed - this seems it. No where else the information of created temporary folders is available. Also the NuGet method does not have any other overloads for NOT creating this ...
Added a hotfix which deletes temporary folders created by NuGet
|
Thanks @ChrSteinert! We're revving up to do a release (FINALLY) |
|
Awesome. Really looking forward to it! |
4 participants
This fixes #1053 temporarily until NuGet fixes this.
Because the files are not used in any manner (at least I have not found any) they can safely be removed.