Skip to content

restore deprecated Common.Logging overloads #847 #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
filipw merged 1 commit into from
Jul 29, 2015
Merged

restore deprecated Common.Logging overloads #847 #1068

filipw merged 1 commit into from
Jul 29, 2015

Conversation

@adamralph
Copy link
Contributor

@adamralph adamralph commented Jul 28, 2015

Fixes #847

This restores all the Common.Logging members as per version 0.14.1.

@adamralph
Copy link
Contributor Author

adamralph commented Jul 28, 2015

Comparing the branch to 0.14.1 is a little challenging since there have been so many other changes since, but it the diff can be seen at v0.14.1...adamralph:847

@adamralph
Copy link
Contributor Author

adamralph commented Jul 28, 2015

Incidentally, we may be able to use the ParticularLabs APIComparer to perform a static analysis of breaking changes between 0.14.1 and the 847 branch. See https://github.com/ParticularLabs/APIComparer/blob/b207b536d6898980192f695def2b503adcbf9127/APIComparer/Program.cs#L18

@adamralph adamralph added the hold label Jul 28, 2015
@adamralph
Copy link
Contributor Author

adamralph commented Jul 28, 2015

Travis is broken because of NuGet.Core renaming shenanigans. That should be fixed by #1069, which can go in before this PR.

@adamralph adamralph removed the hold label Jul 28, 2015
@adamralph
Copy link
Contributor Author

adamralph commented Jul 28, 2015

This should be good to go now.

@adamralph adamralph mentioned this pull request Jul 28, 2015
Closed
29 tasks
@adamralph adamralph changed the title restore deprecated Common.Logging overloads #847 restore deprecated Common.Logging overloads Jul 29, 2015
@adamralph adamralph changed the title #847 restore deprecated Common.Logging overloads restore deprecated Common.Logging overloads #847 Jul 29, 2015
@adamralph adamralph added the P1 label Jul 29, 2015
@filipw
Copy link
Member

filipw commented Jul 29, 2015

ok great job, but i have trouble comprehending how does Autofac choose the constructor now?

@adamralph
Copy link
Contributor Author

adamralph commented Jul 29, 2015

Dunno, it just works 😝

But actually, we don't do magic scanning and injection, right? We explicitly register types in RuntimeServices and wotnot? (I'm easily lost in this part of the codebase.)

@khellang
Copy link
Member

khellang commented Jul 29, 2015

Since we don't register a Common.Logging.ILog, but a ILogProvider, Autofac can only satisfy one ctor 😄

@filipw
Copy link
Member

filipw commented Jul 29, 2015

ah!

@filipw
Copy link
Member

filipw commented Jul 29, 2015

LGTM

filipw added a commit that referenced this pull request Jul 29, 2015
@filipw
Merge pull request #1068 from adamralph/847
3b730c6 
restore deprecated Common.Logging overloads #847
@filipw filipw merged commit 3b730c6 into scriptcs:dev Jul 29, 2015
@adamralph
Copy link
Contributor Author

adamralph commented Jul 29, 2015

woot! thanks @filipw

@adamralph adamralph deleted the 847 branch July 29, 2015 11:23
@glennblock glennblock added this to the v0.16 milestone Apr 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

child PR P1

Projects

None yet

Milestone

v0.16

Development

Successfully merging this pull request may close these issues.

4 participants

@adamralph @filipw @khellang @glennblock