Skip to content

Conversation

@adamralph
Copy link
Contributor

closes #1040

@adamralph
Copy link
Contributor Author

As an aside, it seems like Travis CI has become a lot more stable all of a sudden. All builds seem to be green on the first build.

@lukebuehler
Copy link
Contributor

@adamralph, thanks! sorry about this.

@glennblock
Copy link
Contributor

@adamralph anything holding this up from merging?

@adamralph
Copy link
Contributor Author

@glennblock nope, good to go. Assuming we are OK with the breaking change to IScriptExecutor. The Namespaces property is changing from Collection<string> to IReadOnlyCollection<string>.

@glennblock
Copy link
Contributor

Ugh breaking change. That will break all hosts.
On Thu, Jul 2, 2015 at 1:38 PM Adam Ralph notifications@github.com wrote:

@glennblock https://github.com/glennblock nope, good to go. Assuming we
are OK with the breaking change to IScriptExecutor. The Namespaces
property is changing from Collection to
IReadOnlyCollection.


Reply to this email directly or view it on GitHub
#1042 (comment).

@adamralph adamralph added the hold label Jul 29, 2015
@glennblock
Copy link
Contributor

OK having thought this over, it seems reasonable. If it breaks hosts, it will be minor change in the code.

@glennblock glennblock merged commit eb3bddd into scriptcs:dev Jul 29, 2016
@glennblock
Copy link
Contributor

Looks like suddenly this is breaking the build

@glennblock
Copy link
Contributor

Well I ran the build locally and worked fine with all acceptance tests. It may be a Travis acting up.

@adamralph adamralph deleted the 1040 branch July 30, 2016 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make ScriptExecutor namespaces immutable and make import/remove methods virtual

3 participants