Skip to content

Conversation

@lukebuehler
Copy link
Contributor

Small breaking change if people changed IScriptExecutor.Namespaces directly or kept a reference to it somewhere else (assuming it will be update when the namespaces change)

@lukebuehler
Copy link
Contributor Author

refs #1040

@adamralph
Copy link
Contributor

@lukebuehler can you please rebase your branch onto the upstream dev branch?

@lukebuehler
Copy link
Contributor Author

@adamralph done

@lukebuehler
Copy link
Contributor Author

@adamralph oh crap, did I just mess up the rebase?

@adamralph
Copy link
Contributor

I'm mobile right now, but I'll take a look asap. The easiest thing to do to
avoid these kinds of problems is to always commit to a branch off dev,
rather than dev itself.

On 16:05, Fri, 8 May 2015 Lukas Buhler notifications@github.com wrote:

@adamralph https://github.com/adamralph oh crap, did I just mess up the
rebase?


Reply to this email directly or view it on GitHub
#1041 (comment).

@adamralph
Copy link
Contributor

It looks like you did a merge instead of a rebase.

Not to worry, I'll cherry pick your commit and merge it manually.

As I say, for future ref, if you always work off a feature branch, you'll avoid this problem.

@adamralph
Copy link
Contributor

Instead of merging manually I raised another PR containing your commit - #1042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants