fix: change number regex to not use lookbehind (#106)#107
Merged
scriptcoded merged 1 commit intoscriptcoded:masterfrom Mar 16, 2023
tmadeira:safari
Merged
fix: change number regex to not use lookbehind (#106)#107scriptcoded merged 1 commit intoscriptcoded:masterfrom tmadeira:safari
scriptcoded merged 1 commit intoscriptcoded:masterfrom
tmadeira:safari
Conversation
scriptcoded
approved these changes
Mar 16, 2023
Owner
scriptcoded
left a comment
scriptcoded
left a comment
There was a problem hiding this comment.
While I don't have access to Safari I see this is an issue and am kind of ashamed I hadn't thought about it 🙈
The tests pass and checking for a word boundary should work pretty much exactly the same. Just a note for the sake of documenting, technically a word character is not the same as what's currently being matched, but in this case I don't think it matters. And it solves the issue.
Thanks for the PR!
Owner
|
I'll release this later tonight unless anything else pops up here as I don't follow a set release schedule. |
Contributor
Author
|
@scriptcoded Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid crashing Safari and other browsers which do not support lookbehind in JS regular expressions (https://caniuse.com/js-regexp-lookbehind), fixes #106.