Skip to content

Commit f2da2b1

Browse files
committed
add checkstyle rules, fix MissingOverride rule
1 parent 3773156 commit f2da2b1

File tree

4 files changed

+13
-0
lines changed

4 files changed

+13
-0
lines changed

checkstyle.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,12 @@
55

66
<module name="Checker">
77
<property name="charset" value="UTF-8"/>
8+
<module name="TreeWalker">
9+
<module name="AnnotationLocation">
10+
<property name="allowSamelineSingleParameterlessAnnotation" value="false"/>
11+
</module>
12+
<module name="AnnotationUseStyle"/>
13+
<module name="MissingDeprecated"/>
14+
<module name="MissingOverride"/>
15+
</module>
816
</module>

scribejava-core/src/main/java/com/github/scribejava/core/extractors/BaseStringExtractorImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ public class BaseStringExtractorImpl implements BaseStringExtractor {
1919
/**
2020
* {@inheritDoc}
2121
*/
22+
@Override
2223
public String extract(AbstractRequest request) {
2324
checkPreconditions(request);
2425
String verb = OAuthEncoder.encode(getVerb(request));

scribejava-core/src/main/java/com/github/scribejava/core/services/RSASha1SignatureService.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ public RSASha1SignatureService(PrivateKey privateKey) {
2323
/**
2424
* {@inheritDoc}
2525
*/
26+
@Override
2627
public String getSignature(String baseString, String apiSecret, String tokenSecret) {
2728
try {
2829
Signature signature = Signature.getInstance(RSA_SHA1);
@@ -41,6 +42,7 @@ private String bytesToBase64String(Signature signature) throws SignatureExceptio
4142
/**
4243
* {@inheritDoc}
4344
*/
45+
@Override
4446
public String getSignatureMethod() {
4547
return METHOD;
4648
}

scribejava-core/src/main/java/com/github/scribejava/core/services/TimestampServiceImpl.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ public TimestampServiceImpl() {
2121
/**
2222
* {@inheritDoc}
2323
*/
24+
@Override
2425
public String getNonce() {
2526
Long ts = getTs();
2627
return String.valueOf(ts + timer.getRandomInteger());
@@ -29,6 +30,7 @@ public String getNonce() {
2930
/**
3031
* {@inheritDoc}
3132
*/
33+
@Override
3234
public String getTimestampInSeconds() {
3335
return String.valueOf(getTs());
3436
}

0 commit comments

Comments
 (0)