Add proxy option to JDKHttpClient

bjournaud · bjournaud · commit 3f1cd63ae5c4 · 2020-01-23T18:15:46.000+01:00
diff --git a/scribejava-core/src/main/java/com/github/scribejava/core/httpclient/jdk/JDKHttpClient.java b/scribejava-core/src/main/java/com/github/scribejava/core/httpclient/jdk/JDKHttpClient.java
@@ -115,7 +115,12 @@ public Response execute(String userAgent, Map<String, String> headers, Verb http
 
     private Response doExecute(String userAgent, Map<String, String> headers, Verb httpVerb, String completeUrl,
             BodyType bodyType, Object bodyContents) throws IOException {
-        final HttpURLConnection connection = (HttpURLConnection) new URL(completeUrl).openConnection();
+        final HttpURLConnection connection;
+        if (config.getProxy() == null) {
+            connection = (HttpURLConnection) new URL(completeUrl).openConnection();
+        }else {
+            connection = (HttpURLConnection) new URL(completeUrl).openConnection(config.getProxy());
+        }
         connection.setInstanceFollowRedirects(config.isFollowRedirects());
         connection.setRequestMethod(httpVerb.name());
         if (config.getConnectTimeout() != null) {
diff --git a/scribejava-core/src/main/java/com/github/scribejava/core/httpclient/jdk/JDKHttpClientConfig.java b/scribejava-core/src/main/java/com/github/scribejava/core/httpclient/jdk/JDKHttpClientConfig.java
@@ -1,12 +1,15 @@
 package com.github.scribejava.core.httpclient.jdk;
 
+import java.net.Proxy;
+
 import com.github.scribejava.core.httpclient.HttpClientConfig;
 
 public class JDKHttpClientConfig implements HttpClientConfig {
 
     private Integer connectTimeout;
     private Integer readTimeout;
     private boolean followRedirects = true;
+    private Proxy proxy;
 
     @Override
     public JDKHttpClientConfig createDefaultConfig() {
@@ -37,6 +40,14 @@ public boolean isFollowRedirects() {
         return followRedirects;
     }
 
+    public void setProxy(Proxy proxy) {
+        this.proxy = proxy;
+    }
+
+    public Proxy getProxy() {
+        return proxy;
+    }
+
     /**
      * Sets whether the underlying Http Connection follows redirects or not.
      *
