Skip to content

Commit f8e8ccf

Browse files
committed
fix incorrect exclusion of The
1 parent 7b31fda commit f8e8ccf

2 files changed

Lines changed: 18 additions & 1 deletion

File tree

‎name-parser.test.ts‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -584,6 +584,23 @@ test.each([
584584
suffix: "Sr",
585585
},
586586
},
587+
{
588+
name: "Theodor Rodriguez Sr.",
589+
result: {
590+
firstName: "Theodor",
591+
initials: "T.",
592+
lastName: "Rodriguez",
593+
suffix: "Sr",
594+
},
595+
},
596+
{
597+
name: "By Theodor Rodriguez",
598+
result: {
599+
firstName: "Theodor",
600+
initials: "T.",
601+
lastName: "Rodriguez",
602+
},
603+
},
587604
])("Check Name: %s", ({ name, result }) => {
588605
expect(NameParser.parse(name)).toEqual(result);
589606
});

‎name-parser.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export const NameParser = (function () {
3333
!(
3434
namePart.includes("(") ||
3535
namePart.includes(")") ||
36-
namePart.includes("The")
36+
namePart === "The"
3737
)
3838
);
3939

0 commit comments

Comments
 (0)