Skip to content

db credential vault - #161

Open
breadchris wants to merge 6 commits into
scratchdata:mainfrom
breadchris:aws-secret-manager-126
Open

breadchris wants to merge 6 commits into
scratchdata:mainfrom
breadchris:aws-secret-manager-126

Conversation

@breadchris

@breadchris breadchris commented Apr 15, 2024

Copy link
Copy Markdown
Contributor

Closes #126

Screenshot 2024-04-16 at 11 19 55 AM

Comment thread pkg/destinations/destinations.go Outdated
@breadchris
breadchris marked this pull request as ready for review April 16, 2024 17:25
Comment thread pkg/destinations/destinations.go Outdated
Comment thread pkg/storage/vault/aws/aws.go Outdated
Comment thread pkg/storage/vault/aws/aws.go Outdated
Comment thread pkg/destinations/destinations.go Outdated
@poundifdef

Copy link
Copy Markdown
Contributor

service.go:DeleteDestination() should also remove from vault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use a AWS Secret Manager for DB credentials

2 participants