remove instantiation of SPxLPBase<Rational>

svigerske · svigerske · commit 814ecb0da6ef · 2025-11-20T15:11:33.000+01:00
- to avoid that it is instantiated every time the header gets included
- this would fix scip#3954, where the soplex headers are included by two
  SoPlex interfaces
- remove empty spxlpbase_rational.cpp - it was already no longer compiled
diff --git a/CHANGELOG b/CHANGELOG
@@ -25,6 +25,7 @@ build system:
 
 fixed bugs:
 - extend memory counters to size_t to avoid segmentation faults for large-scale problems
+- removed instantiation of SPxLPBase<Rational> class template from header file, to avoid problems when SoPlex headers are compiled into several object files of a library
 
 code quality:
 - avoid deprecated implicit copy constructor for classes SPxException, SLinSolver, and SLinSolverRational
diff --git a/src/soplex/spxlpbase_rational.cpp b/src/soplex/spxlpbase_rational.cpp
diff --git a/src/soplex/spxlpbase_rational.hpp b/src/soplex/spxlpbase_rational.hpp
@@ -2464,9 +2464,4 @@ void SPxLPBase<Rational>::buildDualProblem(SPxLPBase<Rational>& dualLP, SPxRowId
    SPX_MSG_ERROR(std::cerr << "Method buildDualProblem() not implemented for Rational\n");
 }
 
-
-// ---------------------------------------------------------------------------------------------------------------------
-//  Explicit instantiation
-// ---------------------------------------------------------------------------------------------------------------------
-template class SPxLPBase < Rational >;
 } // namespace soplex

Original file line number	Diff line number	Diff line change
`@@ -2464,9 +2464,4 @@ void SPxLPBase<Rational>::buildDualProblem(SPxLPBase<Rational>& dualLP, SPxRowId`
`2464`	`2464`	`SPX_MSG_ERROR(std::cerr << "Method buildDualProblem() not implemented for Rational\n");`
`2465`	`2465`	`}`
`2466`	`2466`
`2467`		`-`
`2468`		`-// ---------------------------------------------------------------------------------------------------------------------`
`2469`		`-// Explicit instantiation`
`2470`		`-// ---------------------------------------------------------------------------------------------------------------------`
`2471`		`-template class SPxLPBase < Rational >;`
`2472`	`2467`	`} // namespace soplex`