Added redcost method to Variable.rs
#269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmghannam
reviewed
Nov 25, 2025
mmghannam
reviewed
Nov 25, 2025
Co-authored-by: Mohammed Ghannam <mohammad.m.ghannam@gmail.com>
Contributor
Author
|
I made a mistake in 'redcost' I believe. I'll fix it in a bit |
mmghannam
reviewed
Nov 27, 2025
Now this method is called in the `redcost`-method of the `Variable`-struct.
Now, we do not check if the variable is in the LP anymore. Instead, we simply check if the variable has a column associated with it. This is because newly generated columns will not be in the LP, however they are columns and can have reduced cost associated with them.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
+ Coverage 76.49% 76.81% +0.32%
==========================================
Files 29 29
Lines 3871 3915 +44
==========================================
+ Hits 2961 3007 +46
+ Misses 910 908 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I saw the Let me know if you think it is not okay to merge! 😄 |
mmghannam
changed the title
get_redcost method to Variable.rsredcost method to Variable.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I am not certain about this one;
If C returns
SCIP_INVALID, I think this method should returnNoneinstead.SCIPgetVarRedcostcan returnSCIP_INVALIDas per the docs. I believe that I once observed this to be equal to 1e100 in Rust (instead of the declared 1e99). I could not findSCIP_INVALIDinscip-sys, is this something I should add there first?So, for the moment, maybe do not merge this. Just looking for a second opinion