-
Notifications
You must be signed in to change notification settings - Fork 18
add functionality to get children of a node #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Yikes, something goes wrong in col.rs@test_col. This only happens for As you guys are probably pretty busy with the new release of SCIP, I will try and check later this week if I can compile locally against SCIP 10.0! |
Feel free to change the pipeline for now to use SCIP 9.2.4. Thank you for your contribution! It looks good to me on a first glance, I'll take another look sometime in the next days. |
I can't think of an easier solution than what you did. As far as I know, the |
Alright! Good to know, thanks! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 76.37% 76.49% +0.12%
==========================================
Files 29 29
Lines 3830 3871 +41
==========================================
+ Hits 2925 2961 +36
- Misses 905 910 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi Mo!
I needed to access children of a node in a pet-project of mine, thought I would add the functionality.
Tests should be included as well!
Maybe unrelated, feel free to not answer;
I tried creating a custom branching-rule that should work together with the already existing ones in SCIP. All the branching decisions that my rule makes throughout the tree, should be passed on to all of the node's descendants. For this, I keep a BTreeMap that is indexed by the node index and contains all the decisions made for a node (similar to the Ryan-Foster branching from the examples).
However, if SCIP uses its own branching rules, then the indexes of the Map were not updated. Therefore I added an event handler that is called after branching. This way I can simply update the Map manually. Do you think that this is the best way of tackling this issue? Or should I use the SCIP_BranchruleData that is written about in the documentation?