Skip to content

Adds transformed method to Constraint #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmghannam merged 6 commits into from
Apr 22, 2025
Merged

Adds transformed method to Constraint #234

mmghannam merged 6 commits into from
Apr 22, 2025

Conversation

@bgraf
Copy link
Contributor

@bgraf bgraf commented Apr 19, 2025 •
edited
Loading

closes #233

bgraf
bgraf commented Apr 20, 2025
View reviewed changes
mmghannam
mmghannam requested changes Apr 21, 2025
View reviewed changes
Copy link
Member

@mmghannam mmghannam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bgraf for the useful contribution! I added a small comment. It would also be nice to have a test for this new method, otherwise ready to merge :)

@bgraf bgraf requested a review from mmghannam April 21, 2025 16:54
mmghannam
mmghannam approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@mmghannam mmghannam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @bgraf!

@mmghannam mmghannam merged commit c7ce00a into scipopt:main Apr 22, 2025
8 checks passed
@mmghannam mmghannam mentioned this pull request Apr 22, 2025
Open
@bgraf bgraf deleted the transformed_cons branch April 22, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmghannam mmghannam mmghannam approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add safe way to get transformed constraints

2 participants

@bgraf @mmghannam