Skip to content

Use correct mutability symantics for row #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmghannam merged 2 commits into from
Jan 13, 2025
Merged

Use correct mutability symantics for row #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d9890d
Use correct mutability symantics for row
mmghannam Jan 13, 2025
1978816
Fix test
mmghannam Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/row.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,12 @@ impl Row {
}

/// Sets the rank of the row.
pub fn set_rank(&self, rank: usize) {
pub fn set_rank(&mut self, rank: usize) {
unsafe { ffi::SCIProwChgRank(self.raw, rank as c_int) };
}

/// Sets the coefficient of a variable in the row.
pub fn set_coeff(&self, var: &Variable, coeff: f64) {
pub fn set_coeff(&mut self, var: &Variable, coeff: f64) {
unsafe { ffi::SCIPaddVarToRow(self.scip.raw, self.raw, var.raw, coeff) };
}
}
Expand Down Expand Up @@ -249,7 +249,7 @@ mod tests {
_event: Event,
) {
let first_cons = model.conss()[0].clone();
let row = first_cons.row().unwrap();
let mut row = first_cons.row().unwrap();
assert_eq!(row.n_non_zeroes(), 1);
assert_eq!(row.lhs(), 1.0);
assert_eq!(row.index(), 0);
Expand Down
2 changes: 1 addition & 1 deletion src/separator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ mod tests {
sepa: SCIPSeparator,
) -> SeparationResult {
// adds a row representing the sum of all variables == 5, causing infeasibility
let row = sepa
let mut row = sepa
.create_empty_row(&model, "test", 5.0, 5.0, true, false, false)
.unwrap();
for var in model.vars() {
Expand Down
Loading