Could you please push the rendered version on a gh-pages / github.io repo of your own so that we can easily review the rendered HTML / CSS in a browser?

This can be review at
http://scikit-learn.byethost7.com

doesn't look quite right. Firefox 38.0

It does look right. This 3 bar icon, that has nowadays developed into a standard of the hidden menu is presented.
I do agree that the way it is presented is not the nicest. I'm listening for more explicit design comments.

The placement doesn't make it looks like a context menu button. I didn't recognize it as such, so I thought it was an error.
Was there a reason to change the style together with the js?
And usually this icon is use to show a context menu, not hide it, right?

The placement doesn't make it looks like a context menu button. I didn't recognize it as such, so I thought it was an error.

I agree, it was placed where the hide sidebar block was before. But I'm not sure where to put it now, on top of the sidebar might give more the standard feeling?

Was there a reason to change the style together with the js?

Yes, it was easier for me. The old block was harder to control, certainly that specific way the div elements were handled contributed to the bug in the CSS+JS version.

And usually this icon is use to show a context menu, not hide it, right?

Yes, but for that behavior you need to reduce the screen size. Then the default is hidden, and the context menu shows it. But on big screen, the default is to have the menu.

Ok so if we want to keep that button, I feel it should be between the next and previous buttons, or maybe to the left / above the "previous" / "next" bar.
It should also have a button styling. We don't have any drop-shadows or borders on the page, so maybe that wouldn't be good, but at least a rectangle with rounded corners or something that shows that it is clickable would be good.

maybe we can summon @glouppe to give some helpful input?

This is a second review. This time the hide sidebar recovers as possible the old style. Review at
http://scikit-learn.byethost7.com

lgtm

Looks like the last letter in the sidebar content is hidden by the sidebar toggle button, e.g. the 's' in Dummy estimators or the 'e' in Kernel Ridge regression. I checked this happens for both Firefox and Chrome.

Also is there an easy way to make the sidebar toggle button take the whole space vertically speaking?

Looks like the last letter in the sidebar content is hidden by the sidebar toggle button, e.g. the 's' in Dummy estimators or the 'e' in Kernel Ridge regression. I checked this happens for both Firefox and Chrome.

[] I didn't notice this, I'll shift the toggle button more to the left

Also is there an easy way to make the sidebar toggle button take the whole space vertically speaking?

The whole vertical space of whom?

• Size of the left navigation bar?: Not to hard as they are in the same div container. Still design problem on how it should behave on scrolling the page. Now it scrolls with you on a fixed position.
• Size of the content on the right?: A lot harder, change html layout and because the toggle button would be contained inside the same div content element it is shifting, the CSS relative and absolute positioning becomes a mess
• Size of the vertical screen?: Maybe easier, but requires a more serious layout(website) design

The whole vertical space of whom?

Size of the left navigation bar?: Not to hard as they are in the same div container. Still design problem on how it should behave on scrolling the page. Now it scrolls with you on a fixed position.

This option sounds reasonable.

Shift done and also larger toogle button.

Would you mind using « and » rather than << and >> for the toggle content? At the moment it seems a bit big.

Done!

Looks fine, thanks!

This is excellent work @Titan-C . Thanks heaps!

Merging

Indeed. I had not noticed this off centering in the homepage and the documentation page. I reopened the branch and an new PR #4859. The fix is simple one has to delete the css for the div.container-index that compensates the old javascript behavior. It is not needed anymore. I'm also wondering if one should deleted this