Skip to content

Conversation

@francoisgoupil
Copy link
Member

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • Reorganize sponsors into tiers: Founding (Inria), Gold (Chanel), Silver (BNP Paribas Group), Bronze (NVIDIA)
  • Remove logos from Past Sponsors section, convert to full-width text format
  • Convert Other contributions section to bullet points
  • Add BNP Paribas Group logo and update sponsor information
  • Add AXA, BNP Cardif, and Dataiku to past consortium sponsors grid
  • Update probabl description to mention sponsorship program management
  • Update footer funding logos
  • Simplify sponsor descriptions for consistency

Any other comments?

- Reorganize sponsors into tiers: Founding (Inria), Gold (Chanel), Silver (BNP Paribas Group), Bronze (NVIDIA)
- Remove logos from Past Sponsors section, convert to full-width text format
- Convert Other contributions section to bullet points
- Add BNP Paribas Group logo and update sponsor information
- Add AXA, BNP Cardif, and Dataiku to past consortium sponsors grid
- Update probabl description to mention sponsorship program management
- Update footer funding logos
- Simplify sponsor descriptions for consistency
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 89768e3. Link to the linter CI: here

Copy link
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the doc build is picky and complaining about too short underlines or something like this, let's try to fix them all at once.

Copy link
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this seems fine to me!

Having someone outside Probabl give a quick look would be nice, e.g @betatim @lucyleeow or @OmarManzoor?

The main change is the reorg of the funding section to display different tiers (gold, silver, etc ...) and update the information:

- Replace bnp-paribas.png with bnp-paribas.jpg
- Add NVidia funding entry for Tim Head
- Add JavaScript to make external links open in new tab
@ArturoAmorQ ArturoAmorQ changed the title Update sponsor page: reorganize sponsors and add BNP Paribas Group DOC Update sponsor page: reorganize sponsors and add BNP Paribas Group Nov 4, 2025
Copy link
Member

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit and a question but LGTM! Thanks

doc/about.rst Outdated
}
});
}
// Also handle links anywhere on the page if on about.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does 'handle links' mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That second part isn’t really needed here. It’s just a defensive fallback I added in case the page didn’t wrap its content in a #about element, or if the same script were reused elsewhere. Since on about.html everything is already inside the #about section, we can safely remove that second block. I guess.

Co-authored-by: Lucy Liu <jliu176@gmail.com>
Copy link
Member Author

@francoisgoupil francoisgoupil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing unnecessary JS code

doc/about.rst Outdated
}
});
}
// Also handle links anywhere on the page if on about.html
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That second part isn’t really needed here. It’s just a defensive fallback I added in case the page didn’t wrap its content in a #about element, or if the same script were reused elsewhere. Since on about.html everything is already inside the #about section, we can safely remove that second block. I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants