-
-
Notifications
You must be signed in to change notification settings - Fork 26.4k
DOC Update sponsor page: reorganize sponsors and add BNP Paribas Group #32642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
DOC Update sponsor page: reorganize sponsors and add BNP Paribas Group #32642
Conversation
- Reorganize sponsors into tiers: Founding (Inria), Gold (Chanel), Silver (BNP Paribas Group), Bronze (NVIDIA) - Remove logos from Past Sponsors section, convert to full-width text format - Convert Other contributions section to bullet points - Add BNP Paribas Group logo and update sponsor information - Add AXA, BNP Cardif, and Dataiku to past consortium sponsors grid - Update probabl description to mention sponsorship program management - Update footer funding logos - Simplify sponsor descriptions for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the doc build is picky and complaining about too short underlines or something like this, let's try to fix them all at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, this seems fine to me!
Having someone outside Probabl give a quick look would be nice, e.g @betatim @lucyleeow or @OmarManzoor?
The main change is the reorg of the funding section to display different tiers (gold, silver, etc ...) and update the information:
- Replace bnp-paribas.png with bnp-paribas.jpg - Add NVidia funding entry for Tim Head - Add JavaScript to make external links open in new tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit and a question but LGTM! Thanks
doc/about.rst
Outdated
| } | ||
| }); | ||
| } | ||
| // Also handle links anywhere on the page if on about.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does 'handle links' mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That second part isn’t really needed here. It’s just a defensive fallback I added in case the page didn’t wrap its content in a #about element, or if the same script were reused elsewhere. Since on about.html everything is already inside the #about section, we can safely remove that second block. I guess.
Co-authored-by: Lucy Liu <jliu176@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing unnecessary JS code
doc/about.rst
Outdated
| } | ||
| }); | ||
| } | ||
| // Also handle links anywhere on the page if on about.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That second part isn’t really needed here. It’s just a defensive fallback I added in case the page didn’t wrap its content in a #about element, or if the same script were reused elsewhere. Since on about.html everything is already inside the #about section, we can safely remove that second block. I guess.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?