FIX warn if an estimator does have a concrete __sklearn_tags__ implementation #30516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Dec 22, 2024
LiorxCohen
reviewed
Dec 29, 2024
LiorxCohen
left a comment
LiorxCohen
left a comment
There was a problem hiding this comment.
didnt understand how did you fix that bug
thomasjpfan
reviewed
Jan 3, 2025
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre
commented
Jan 3, 2025
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
jeremiedbb
reviewed
Jan 3, 2025
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
Member
|
So we intend to always raise and require inheriting from BaseEstimator in 1.7 ? Let's mention the version in the warning message and add a comment to remind us to clean up in 1.7 |
Member
Author
Not really, you could just implement |
Member
Author
|
I modify the warning slightly to add the version for erroring and discourage defining |
jeremiedbb
reviewed
Jan 3, 2025
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
jeremiedbb
approved these changes
Jan 6, 2025
|
When will this be updated in the library on Google Colab? I just ran into this issue when I was trying to use it with the skorch library. I am unfamiliar with the timeline these fixes are corrected. |
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jan 8, 2025
…entation (scikit-learn#30516) Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jan 8, 2025
…entation (scikit-learn#30516) Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
jeremiedbb
added a commit
that referenced
this pull request
Jan 9, 2025
…entation (#30516) Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30479
Catch the error in the case that there is no
__sklearn_tags__implementation in the MRO. We return the default tags and request to inherit fromBaseEstimatorthat implements it.