Skip to content

Use a better value for the default groupId #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dscho merged 1 commit into from
Sep 26, 2014
Merged

Use a better value for the default groupId #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/scijava/plugins/scripting/java/JavaEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
*/
public class JavaEngine extends AbstractScriptEngine {

private final static String DEFAULT_GROUP_ID = "net.imagej";
private final static String DEFAULT_GROUP_ID = "org.scijava.scripting.java";
private final static String DEFAULT_VERSION = "1.0.0-SNAPSHOT";

/**
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/scijava/plugins/scripting/java/JavaEngineTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ private File makeProject(final String mainClass, final String... args)
" xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0\n" + //
" http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n" + //
" <modelVersion>4.0.0</modelVersion>\n" + //
" <groupId>net.imagej</groupId>\n" + //
" <groupId>org.scijava.scripting.java</groupId>\n" + //
" <artifactId>MinimalTest</artifactId>\n" + //
" <version>1.0.0</version>\n" + //
" <build>\n" + //
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/scijava/plugins/scripting/java/MakeJarTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ public void testSingle() throws Exception {
final File output = new File(tmpDir, "test.jar");
engine.makeJar(file, false, output, writer);
assertJarEntries(output, "META-INF/MANIFEST.MF",
"META-INF/maven/net.imagej/Dummy/pom.xml", "Dummy.class");
"META-INF/maven/org.scijava.scripting.java/Dummy/pom.xml", "Dummy.class");
engine.makeJar(file, true, output, writer);
assertJarEntries(output, "META-INF/MANIFEST.MF",
"META-INF/maven/net.imagej/Dummy/pom.xml", "Dummy.class",
"META-INF/maven/org.scijava.scripting.java/Dummy/pom.xml", "Dummy.class",
"pom.xml", "src/main/java/Dummy.java");
}

Expand Down