JavaEngine: fix critical buffering bug

ctrueden · ctrueden · commit 1e9c9fd2906c · 2015-03-19T12:05:59.000-05:00
This fixes Fiji bug #1029: http://fiji.sc/bugzilla/show_bug.cgi?id=1029 The CharBuffer has a position which does not get reset, and so length() returns 0 even when there is data in subsequent read passes. We avoid the issue by using a simple char[] instead of a new-fangled "object". Without this change, Java scripts longer than 1024 characters will produce exceptions like: java.lang.IndexOutOfBoundsException: start 0, end 582, s.length() 442 at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:453) at java.lang.StringBuilder.append(StringBuilder.java:179) at org.scijava.plugins.scripting.java.JavaEngine.getReaderContentsAsString(JavaEngine.java:904) at org.scijava.plugins.scripting.java.JavaEngine.eval(JavaEngine.java:169)
diff --git a/src/main/java/org/scijava/plugins/scripting/java/JavaEngine.java b/src/main/java/org/scijava/plugins/scripting/java/JavaEngine.java
@@ -46,7 +46,6 @@
 import java.net.MalformedURLException;
 import java.net.URL;
 import java.net.URLClassLoader;
-import java.nio.CharBuffer;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.jar.Attributes.Name;
@@ -896,7 +895,7 @@ private static String getReaderContentsAsString(Reader reader)
 			return null;
 		}
 
-		CharBuffer buffer = CharBuffer.allocate(1024);
+		char[] buffer = new char[1024];
 		StringBuilder builder = new StringBuilder();
 
 		int read;
