Skip to content

Engine version = 0.0 #6

Closed
Closed

Description

@mslinn

factory.getEngineVersion return "0.0" which is probably an oversight.

Activity

  1. ctrueden commented on Dec 18, 2017

    @ctrueden
    Member

    Thanks @mslinn. As a step forward, I changed the abstract base layer to return the version of the containing Maven artifact by default. E.g. for this component, this is currently 0.1.7-SNAPSHOT plus hash of built commit. This is the same value already given by getLanguageVersion(). Note that a new version of scijava-common will need to be released, and this component updated to depend on it, in order to guarantee that downstream consumers receive the fix.

    If you have a suggestion for a better value to return for Clojure specifically, we can modify the ClojureScriptLanguage here to invoke whatever API is used to obtain that value.

  2. mslinn commented on Dec 18, 2017

    @mslinn
    Author

    This works for me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions