You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks @mslinn. As a step forward, I changed the abstract base layer to return the version of the containing Maven artifact by default. E.g. for this component, this is currently 0.1.7-SNAPSHOT plus hash of built commit. This is the same value already given by getLanguageVersion(). Note that a new version of scijava-common will need to be released, and this component updated to depend on it, in order to guarantee that downstream consumers receive the fix.
If you have a suggestion for a better value to return for Clojure specifically, we can modify the ClojureScriptLanguage here to invoke whatever API is used to obtain that value.
Activity
ScriptLanguage: give getEngineVersion an OK value
ctrueden commentedon Dec 18, 2017
Thanks @mslinn. As a step forward, I changed the abstract base layer to return the version of the containing Maven artifact by default. E.g. for this component, this is currently
0.1.7-SNAPSHOTplus hash of built commit. This is the same value already given bygetLanguageVersion(). Note that a new version ofscijava-commonwill need to be released, and this component updated to depend on it, in order to guarantee that downstream consumers receive the fix.If you have a suggestion for a better value to return for Clojure specifically, we can modify the
ClojureScriptLanguagehere to invoke whatever API is used to obtain that value.mslinn commentedon Dec 18, 2017
This works for me 👍