Skip to content

Use less restric rules for autoActivation#13

Merged
acardona merged 2 commits into
scijava:mainfrom
tferr:patch-2
Mar 15, 2022
Merged

Use less restric rules for autoActivation#13
acardona merged 2 commits into
scijava:mainfrom
tferr:patch-2

Conversation

@tferr

@tferr tferr commented Feb 27, 2022

Copy link
Copy Markdown
Collaborator

@acardona, when auto-activation is enabled in the TextEditor, this should make so that the auto-completion popup appears mid-word after the default 300ms delay.

This addresses what was discussed in scijava/script-editor#56 (comment)

When Auto-activation is enabled in the  TextEditor, this should make so that the auto-completion
popup appears mid-word after the default 300ms delay
@acardona

acardona commented Mar 1, 2022

Copy link
Copy Markdown
Collaborator

Thanks. Before I merge this: how does one deactivate automatic autocompletion from the GUI? I'd rather use control+space.

Update: I saw the "Show completions without control+space" is activated by default. Fine with me, but does the checkbox work?

@tferr

tferr commented Mar 1, 2022

Copy link
Copy Markdown
Collaborator Author

@acardona, I also dislike the automatic popup. Too distracting. But I am convinced everything is accurate now on the GUI side.

The only reason why that checkbox is active by default is for backwards compatibility with IJ macros. I thought, it would be easier to ask advanced users to turn it off, rather than asking newcomers to turn it on.

Also, the behavior is as follows: Ctrl+Space always works. When "Show completions without control+space" is selected, the popup window also appears after a 300ms pause, but it does not disable the Ctrl+Space invocation.

@tferr

tferr commented Mar 4, 2022

Copy link
Copy Markdown
Collaborator Author

@acardona , can you give me write access to this repository? The release.sh script does not work if I am just a collaborator (or at least I don't get it to work).

@acardona

acardona commented Mar 5, 2022

Copy link
Copy Markdown
Collaborator

Looks like now we can't merge this, must be the change in script-editor version.

@acardona acardona merged commit bcd3277 into scijava:main Mar 15, 2022
@acardona

Copy link
Copy Markdown
Collaborator

Thanks!

@imagesc-bot

Copy link
Copy Markdown

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/auto-code-completion-for-ij-macro/11642/162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants