OptionsLookAndFeel: Support for FlatLaf#65
Merged
Conversation
Member
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: |
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/flatlaf-does-not-seem-to-work-with-fiji/69704/2 |
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/timeline-for-the-next-fiji-update/69640/7 |
This implements support for FlatLaf Look and Feels.
A static method is also included so that Look and Feel can be set at
startup. E.g., for Fjii the following call in the StartupMacros could be
used to set the Look and Feel programmatically at startup:
eval("js","importClass(Packages.org.scijava.ui.swing.options.OptionsLookAndFeel);OptionsLookAndFeel.setupLookAndFeel('FlatLaf Dark');")
NB: there are currently several hardwired foreground/background colors in several classes (e.g., ConsolePanel) that will interfere with dark themes.
Signed-off-by: Curtis Rueden <ctrueden@wisc.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ctrueden, this PR is a proposal on how Flatlaf could be used as an optional L&F for Swing components in Fiji/SciJava in direct response to #61. The advantages of FlatLaf L&Fs are discussed in #61, and include:
This PR also includes a static method so that Look and Feel can be set more easily at startup. E.g., for Fjii the following
call in the StartupMacros could now be used to set the Look and Feel programmatically:
A couple of notes:
setColor()references in the code. I am not doing that here, in case there are technical issues with adopting third-party L&F libraries that I am not foreseeing, and this cannot be merged.