Conversation
To parse the json query result, we use gson, which is managed in pom-scijava already. Also deactivate the old (currently non-functional) forum search.
Unfortunately, this makes the search super slow. We should possibly use some caching for the avatars.
Member
|
Thanks for updating this, @imagejan! Would you be OK with simply removing the old |
ImageForumSearcher wasn't functional anymore due to changes in the discourse settings/API. It's been replaced now by the new ImageScSearcher.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To parse the JSON query result, we use
gson, which is managed inpom-scijavaalready.Also deactivate the old (currently non-functional) forum search.
The second commit is a trial to add the forum avatars as icons in the search panel, but unfortunately it makes the search very slow. Maybe others have a suggestion how to speed it up by caching or deferred loading, maybe also using
DownloadService?If there's no good way to have lazy loading of avatars, I suggest merging only the first commit of this pull request.
Fixes #15, see also #20.