Developer profiles#7
Closed
hinerm wants to merge 2 commits into
Closed
Conversation
As the pom-scijava pom.xml now contains multiple properties ranges, it is not enough to search and replace within the properties tag. A special start/end anchor was added to the pom.xml to define the non-profiled properties section, so this is used instead.
When bumping pom properties, also bump the corresponding properties in any profile sections to the latest SNAPSHOT versions.
Contributor
|
I fear that we cannot really ask Imagine, for example, if someone deploys a new release of, say, |
Member
|
Note that I, as the inconsiderate person that I am, merged I would like to find a different approach to fixing the |
Member
Author
|
@ctrueden yep I am on board. |
Contributor
Member
|
Thanks! |
ctrueden
added a commit
that referenced
this pull request
Oct 22, 2014
Just for you, Dscho! Unfortunately, and surprisingly, performance is not much better: export jar1=org/python/jython-standalone/2.7-b3/jython-standalone-2.7-b3.jar export jar2=org/python/jython-standalone/2.5.3/jython-standalone-2.5.3.jar == Using javap == $ time class-version.sh $jar1 $jar2 org/python/jython-standalone/2.7-b3/jython-standalone-2.7-b3.jar: J2SE 7 (51.0) org/python/jython-standalone/2.5.3/jython-standalone-2.5.3.jar: J2SE 5.0 (49.0) real 0m2.538s user 0m4.616s sys 0m0.810s $ time class-version.sh $jar1 $jar2 org/python/jython-standalone/2.7-b3/jython-standalone-2.7-b3.jar: J2SE 7 (51.0) org/python/jython-standalone/2.5.3/jython-standalone-2.5.3.jar: J2SE 5.0 (49.0) real 0m2.382s user 0m4.467s sys 0m0.786s == Using unzip == $ time class-version.sh $jar1 $jar2 org/python/jython-standalone/2.7-b3/jython-standalone-2.7-b3.jar: J2SE 7 (51.0) org/python/jython-standalone/2.5.3/jython-standalone-2.5.3.jar: J2SE 5.0 (49.0) real 0m3.026s user 0m4.443s sys 0m1.158s $ time class-version.sh $jar1 $jar2 org/python/jython-standalone/2.7-b3/jython-standalone-2.7-b3.jar: J2SE 7 (51.0) org/python/jython-standalone/2.5.3/jython-standalone-2.5.3.jar: J2SE 5.0 (49.0) real 0m3.061s user 0m4.486s sys 0m1.161s == Simplifying further == Even if you cut out the sed and expr commands like so: # extract byte #7 major="$(unzip -p "$jar" "$(jar tf "$jar" | grep \.class$ | head -n 1)" | head -c 8 | hexdump -s 7 -e '1/1 "%d\n"')" The results are no more impressive: $ time class-version.sh $jar1 $jar2 org/python/jython-standalone/2.7-b3/jython-standalone-2.7-b3.jar: J2SE 7 (51) org/python/jython-standalone/2.5.3/jython-standalone-2.5.3.jar: J2SE 5.0 (49) real 0m3.053s user 0m4.526s sys 0m1.151s $ time class-version.sh $jar1 $jar2 org/python/jython-standalone/2.7-b3/jython-standalone-2.7-b3.jar: J2SE 7 (51) org/python/jython-standalone/2.5.3/jython-standalone-2.5.3.jar: J2SE 5.0 (49) real 0m3.063s user 0m4.656s sys 0m1.151s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dscho @ctrueden this PR updates bump-pom-scijava.sh to work with the developer-profiles branch of pom-scijava.
I just wanted @dscho especially to sign off on these changes, that I'm updating the profile properties correctly.
Thanks!