Force locale setting for the script#42
Merged
Merged
Conversation
This avoids localized output that can confuse the script, e.g. when determining the $defaultBranch.
Member
|
Thanks, @ehrenfeu! This change looks safe to me, so I'll go ahead and merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids localized output that can confuse the script, e.g. when determining
the $defaultBranch.
We (as in @lguerard and me) were facing issues when trying to create a new
release using a
fr_FRlocale setting on Linux (Mint 20.1 / Ubuntu 20.04) as thecommand for getting the default branch is failing there (the
greppattern doesn'tmatch on the french locale):
scijava-scripts/release-version.sh
Line 186 in 8bd74a0
PLEASE NOTE: this is entirely untested on MacOS and Windows, although
in my experience using the
Clocale should be supported there as well.