Skip to content

Commit 7b3d228

Browse files
committed
release-version.sh: stop adding Signed-off-by
When making "Bump to next development cycle" commits, the script has for many years passed the -s flag, which appends a Signed-off-by tag to the commit message in the name of the author. The meaning of this tag depends on the project to which it is added, but in general signifies some sort of explicit acknowledgement, approval and/or acceptance of the contents of the commit. For SciJava projects, the Signed-off-by tag does not have a documented meaning, although historically I have always assumed it to mean that the person signing off has legal authority to add that commit's contents to the repository -- i.e.: the commit does not violate anyone's copyright, and the signer is aligning the commit's content with the project license to the extent legally possible. From the gitfaq, justifying why there is no env var for the -s flag: > If there were more automated and widely publicized ways for > sign-offs to be appended, it would become easier for someone to > argue later that a "Signed-off-by" trailer was just added out of > habit or by automation, without the committer’s full awareness or > intent to certify their agreement with the Developer Certificate > of Origin (DCO) or a similar statement. This could undermine the > sign-off’s credibility in legal or contractual situations. Since the content of the "Bump to next development cycle" commits is uncopyrightable in its complexity, it is not exactly harmful to include the tag here, but it is also not exactly helpful: the only scenario I can imagine where I would be happy to have the tag present is if SciJava projects start enforcing substantially more bureaucracy around code contributions than we currently do -- and I very much do not expect that to happen any time soon. So in the interest of less clutter, let's not bother tagging here.
1 parent 235d1d0 commit 7b3d228

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎release-version.sh‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -529,9 +529,9 @@ if ! git diff-index --cached --quiet --ignore-submodules HEAD --
529529
then
530530
if test "$moduleDir"
531531
then
532-
$DRY_RUN git commit -s -m "Bump $artifactId to next development cycle"
532+
$DRY_RUN git commit -m "Bump $artifactId to next development cycle"
533533
else
534-
$DRY_RUN git commit -s -m "Bump to next development cycle"
534+
$DRY_RUN git commit -m "Bump to next development cycle"
535535
fi
536536
fi &&
537537

0 commit comments

Comments
 (0)