Skip to content

Commit 5dba1c1

Browse files
committed
check-release.pl: fix release version detection
When gleaning the latest release from the Maven metadata file, the grep system call (like all system calls from Perl) has a trailing newline. But we do not want to return the version string to include that newline. This bug was likely the cause of some weird behavior in status.imagej.net at various points, including misreporting a component as being dozens or hundreds of commits ahead of the last release.
1 parent 3eb52c8 commit 5dba1c1

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

check-release.pl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ ($)
5757
my $gaPath = $ga;
5858
$gaPath =~ s/[\.:]/\//g;
5959
my $release = `grep release "$cachePath/$gaPath"/*.xml | head -n 1`;
60+
chomp $release;
6061
$release =~ s/.*<release>//;
6162
$release =~ s/<\/release>.*//;
6263
return $release;

0 commit comments

Comments
 (0)