Add switch to ignore optional dependencies #28
Merged
+55
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanslovsky
force-pushed
the
add-switch-to-ignore-optional-dependencies
branch
from
7f21aa4 to
6765840
Compare
Member
|
Thanks a lot, @hanslovsky! Patch looks beautiful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current master branch, the
InstallArtifactMojoignores dependencies marked asoptional, while thePopulateAppMojodoes not. When creating shaded and deploying intoFiji.app, it is necessary to be able to ignore optional dependencies becauseprovideddependencies are ignored both by thePopulateAppMojoand the shade plugin (not just by thePopulateAppMojo), e.g. scijava/scripting-kotlin#6. This PR adds the propertyscijava.ignoreOptionalDependenciesto control this behavior both in theInstallArtifactMojoand thePopulateAppMojo. I decided against simply changingPopulateAppMojoto hard-code ignoring optional dependencies (as is done inInstallArtifactMojo) because it may break some existing builds. For the same reason,PopulateAppMojoandInstallArtifactMojohave different default values forscijava.ignoreOptionalDependencies.