Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: scijava/scijava-maven-plugin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 50a6984
Choose a base ref
...
head repository: scijava/scijava-maven-plugin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c289e4b
Choose a head ref
  • 1 commit
  • 2 files changed
  • 2 contributors

Commits on Oct 24, 2026

  1. RequireReproducibleBuilds: recognize aggregator siblings

    Building a single module of a multi-module project failed this rule for
    every sibling SNAPSHOT dependency, because findEffectiveReactor looked
    for the enclosing project only along the Maven parent chain. A module's
    <parent> is frequently a shared parent POM -- pom-scijava, for these
    projects -- which knows nothing about its siblings, so the effective
    reactor came out as just the one module and each sibling looked like an
    unreleased external artifact.
    
    The aggregator that actually lists the module is discoverable by
    directory instead: the enclosing directory's POM, if it declares this
    project among its <modules>. findEffectiveReactor now recurses into that
    as well as into the parent, so the whole reactor is found from any
    module within it, and from nested aggregators too.
    
    Verified against the scijava/scijava repository, where every module's
    parent is pom-scijava:
    
    - In scijava-ops-api, which depends on six sibling SNAPSHOTs, the rule
      failed before this change and passes after it.
    - In scijava-code-api, which depends on org.scijava:scijava-common
      2.100.2-SNAPSHOT from a different repository, the rule still fails and
      still names that artifact. Sibling snapshots are excused; genuinely
      external ones are not.
    
    Note that SetRootDirPropertyMojo walks the parent chain the same way and
    so has the same blind spot: for these projects it sets rootdir to the
    module's own directory rather than the aggregator's.
    
    The populate-app integration test fails both with and without this
    change.
    
    Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
    Claude-Session: https://claude.ai/code/session_013gJpzGd3ksbME4CN6Tu2ni
    ctrueden and claude committed Oct 24, 2026
    Configuration menu
    Copy the full SHA
    c289e4b View commit details
    Browse the repository at this point in the history
Loading