DefaultJava3DService: clean up style

ctrueden · ctrueden · commit c25ef3161b2d · 2015-10-07T10:34:03.000-05:00
diff --git a/src/main/java/org/scijava/java3d/DefaultJava3DService.java b/src/main/java/org/scijava/java3d/DefaultJava3DService.java
@@ -96,25 +96,30 @@ private void checkLibExtDirectory(final ArrayList<File> files,
 		checkFile(files, new File(dir, "j3dcore.jar"));
 		checkFile(files, new File(dir, "vecmath.jar"));
 		checkFile(files, new File(dir, "j3dutils.jar"));
-		checkFilePattern( files, dir, "j3d-core*");
-		checkFilePattern( files, dir, "vecmath*");
-		checkFilePattern( files, dir, "jogl*");
-		// Maybe libJ3DUtils.jnilib libJ3DAudio.jnilib 
+		checkFilePattern(files, dir, "j3d-core*");
+		checkFilePattern(files, dir, "vecmath*");
+		checkFilePattern(files, dir, "jogl*");
+		// Maybe libJ3DUtils.jnilib libJ3DAudio.jnilib
 	}
-	
-	private void checkFilePattern(ArrayList<File> files, String dir, String argPattern) {
-		final String pattern = argPattern.replace(".","\\.").replace("*",".*");	    
-	    
-	    if( dir.isEmpty() ) dir = ".";
-	    else if( (new File(dir)).exists() ) {
-		    for( File f : new File( dir ).listFiles( new FilenameFilter(){
-		                       public boolean accept( File dir, String name ) { 
-		                           return name.matches( pattern );
-		                       }
-		                    })){
-		    	files.add(f);
-		    }
-	    }
+
+	private void checkFilePattern(final ArrayList<File> files,
+		final String dirPath, final String argPattern)
+	{
+		final String pattern = argPattern.replace(".", "\\.").replace("*", ".*");
+
+		final File dirFile = new File(dirPath.isEmpty() ? "." : dirPath);
+		if (!dirFile.exists()) return;
+
+		final FilenameFilter filter = new FilenameFilter() {
+
+			@Override
+			public boolean accept(final File dir, final String name) {
+				return name.matches(pattern);
+			}
+		};
+		for (final File f : dirFile.listFiles(filter)) {
+			files.add(f);
+		}
 	}
 
 	private void checkFile(ArrayList<File> files, File file) {
