Repository navigation
Work around Windows problems with temporary directories - #72
Merged
Merged
Conversation
Windows really does not let you delete files that are in use, even if "in use" really means that there is a ClassLoader referencing that file and that ClassLoader just happens not to be garbage-collected yet. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
When calling said method from the same code location multiple times, we should still get an empty temporary directory every time, even if there are still-open files in the directory of the default name. For Windows, emptying directories poses an insurmountable problem when they contain files that are still in use, therefore we have to fall back to creating new temporary directories. Identified by Jennyver Jenkins as a problem when building and testing ij1-patcher on Windows. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
that referenced
this pull request
May 26, 2014
Work around Windows problems with temporary directories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hmpf. Windows. Windows is a little different than every normal operating system. Just a little, just different enough to require extra attention. Windows is special. And Windows takes the special bus, once again.
Still needs testing on Windows (which the primary reason to open a PR that I'll probably merge right away, once the testing shows that it works).