Skip to content

DefaultTextService: use try-with-resources #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ctrueden merged 1 commit into from
May 16, 2019
Merged

DefaultTextService: use try-with-resources #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/main/java/org/scijava/text/DefaultTextService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,16 +63,12 @@ public final class DefaultTextService extends
@Override
public String open(final File file) throws IOException {
// This routine is from: http://stackoverflow.com/a/326440
final FileInputStream stream = new FileInputStream(file);
try {
try (final FileInputStream stream = new FileInputStream(file)) {
final FileChannel fc = stream.getChannel();
final MappedByteBuffer bb =
fc.map(FileChannel.MapMode.READ_ONLY, 0, fc.size());
return Charset.defaultCharset().decode(bb).toString();
}
finally {
stream.close();
}
}

@Override
Expand Down