Skip to content

Avoid displaying welcome message when running headless#304

Merged
ctrueden merged 1 commit into
scijava:masterfrom
imagejan:fix-headless-welcome
Oct 31, 2017
Merged

Avoid displaying welcome message when running headless#304
ctrueden merged 1 commit into
scijava:masterfrom
imagejan:fix-headless-welcome

Conversation

@imagejan

@imagejan imagejan commented Oct 29, 2017

Copy link
Copy Markdown
Member

As suggested by @ctrueden in this discussion on the forum.

I didn't have a chance to test this headless yet, so please test before merging.

/cc @sebi06

@ctrueden

Copy link
Copy Markdown
Member

@imagejan When you get a chance, could you please rebase this over the latest master and then force push? I'd like to see if it fixes the Travis build.

@imagejan

Copy link
Copy Markdown
Member Author

@ctrueden wrote:

When you get a chance, could you please rebase this over the latest master and then force push?

I did, but Travis still seems to have problems...

@ctrueden

ctrueden commented Oct 30, 2017

Copy link
Copy Markdown
Member

Travis still seems to have problems...

As mentioned in Gitter, but repeated here for the benefit of others: I pushed a commit to scijava-common which I hope finally fixes the issue: a00f50d. More importantly, I pushed a fix to travisify.sh which will set up new projects correctly in the future: scijava/scijava-scripts@56f0f6e. So hopefully another rebase against latest SJC master followed by force push of your branch will now, finally, have a successful Travis build. Thank you for bearing with me with this unrelated-but-important-to-address issue.

@imagejan

Copy link
Copy Markdown
Member Author

Now Travis says:

An error occurred while generating the build script.

@ctrueden

Copy link
Copy Markdown
Member

@imagejan It was a fluke. I told Travis to restart the build and it worked.

@ctrueden ctrueden merged commit 7aa12be into scijava:master Oct 31, 2017
@ctrueden

Copy link
Copy Markdown
Member

Thanks for fixing this!

@imagejan imagejan deleted the fix-headless-welcome branch October 31, 2017 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants