Locale fixes#170
Merged
Merged
Conversation
The purpose of the UnitUtils is to return back a String for a given number of bytes in the format of the user's Locale. Added javadoc clarifying this
Member
Author
|
@gab1one Would you mind checking out this branch and building it on your machine? It changes the fix you submitted last week to not force US Locale, but instead format the test strings for the current locale.. just want to be sure the unit tests don't fail for you now. Thanks! |
Contributor
|
Sadly that does not work at all (the local() method has no effect), I think we need to split the number from the unit or something. |
Move the numeric formatting to a utility method.
Split the test strings to numeric and label components, and used the same formatting as used in UnitUtils. This should mitigate locale differences.
Member
Author
@gab1one yep I agree. When the test strings contain the numeric value + label, they don't get numeric formatting. Anyway I force pushed a new patch set that should format the test strings the same as UnitUtils. Can you test again? Much thanks. |
Contributor
|
It works now, thank you 👍 |
hinerm
added a commit
that referenced
this pull request
Jun 9, 2015
Removes US Locale bias from UnitUtils and UnitUtilsTest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes UnitUtils non-US-centric, and updates the corresponding unit test to pass in non-US locales.