Skip to content

LogService should have non-consuming Handler plugins #84

Closed

Description

@hinerm

Depends on #83

We already have cases of competing LogServices, e.g. the DefaultLogService and SLF4J. It is becoming clear that there is a need for additional logging functionality, for example in the legacy layer we would like to pass error messages and exceptions to IJ.log or IJ.handleException functionality.

However this is not possible at the moment without competing with other LogService implementations.

Once we can differentiate consuming and non-consuming Handlers, though, we can refactor the DefaultLogService to use non-consuming Handler plugins. Then whichever implementations are present can log a given event as appropriate.

Activity

  1. dscho commented on Jun 13, 2014

    @dscho
    Contributor

    Introducing such a paradigm opens a can of worms, so we might want to go with "meta-handlers" instead that have the highest priority, delegate to the highest-priority non-meta handler, and serve an additional category of plugins: the non-consuming ones. In other words, it might be better to add a different interface altogether for non-consuming loggers and to leverage the existing framework to service them in addition to the default logger.

  2. ctrueden commented on Mar 23, 2015

    @ctrueden
    Member

    For the case of logging stdout/stderr specifically, the issue is now solved with #152. I am not seeing another immediate use case for non-consuming handlers. We sort of have a pattern like that already with the ConsoleArgument and ConsoleService; let's not complicate things any further for now, until/unless a clear need arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions