Skip to content

Commit ab408b6

Browse files
awalter17ctrueden
authored andcommitted
Changed testPrimitive to use getPrimitiveType method
1 parent 8894402 commit ab408b6

File tree

1 file changed

+3
-76
lines changed

1 file changed

+3
-76
lines changed

src/test/java/org/scijava/convert/AbstractNumberConverterTests.java

Lines changed: 3 additions & 76 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,10 @@
3434
import static org.junit.Assert.assertEquals;
3535
import static org.junit.Assert.assertTrue;
3636

37-
import java.math.BigDecimal;
38-
import java.math.BigInteger;
39-
4037
import org.junit.Rule;
4138
import org.junit.Test;
4239
import org.junit.rules.ExpectedException;
40+
import org.scijava.util.ConversionUtils;
4341

4442
/**
4543
* Tests converter plugins that convert from primitive numeric types to other
@@ -81,79 +79,8 @@ public void testWrapper() {
8179
public void testPrimitive() {
8280
final Number src = getSrc();
8381
final Number expect = getExpectedValue();
84-
if (!destType.equals(BigInteger.class) &&
85-
!destType.equals(BigDecimal.class))
86-
{
87-
// byte to number converters
88-
if (srcType.equals(Byte.class)) {
89-
final byte b = src.byteValue();
90-
if (destType.equals(Short.class)) {
91-
final short s = expect.shortValue();
92-
assertTrue(s == converter.convert(b, short.class));
93-
}
94-
else if (destType.equals(Integer.class)) {
95-
final int i = expect.intValue();
96-
assertTrue(i == converter.convert(b, int.class));
97-
}
98-
else if (destType.equals(Long.class)) {
99-
final long l = expect.longValue();
100-
assertTrue(l == converter.convert(b, long.class));
101-
}
102-
else if (destType.equals(Float.class)) {
103-
final float f = expect.floatValue();
104-
assertTrue(f == converter.convert(b, float.class));
105-
}
106-
else {
107-
final double d = expect.doubleValue();
108-
assertTrue(d == converter.convert(b, double.class));
109-
}
110-
}
111-
// int to number converters
112-
else if (srcType.equals(Integer.class)) {
113-
final int i = src.intValue();
114-
if (destType.equals(Long.class)) {
115-
final long l = expect.longValue();
116-
assertTrue(l == converter.convert(i, long.class));
117-
}
118-
else {
119-
final double d = expect.doubleValue();
120-
assertTrue(d == converter.convert(i, double.class));
121-
}
122-
}
123-
// short to number converters
124-
else if (srcType.equals(Short.class)) {
125-
final short s = src.shortValue();
126-
if (destType.equals(Integer.class)) {
127-
final int i = expect.intValue();
128-
assertTrue(i == converter.convert(s, int.class));
129-
}
130-
else if (destType.equals(Long.class)) {
131-
final long l = expect.longValue();
132-
assertTrue(l == converter.convert(s, long.class));
133-
}
134-
else if (destType.equals(Float.class)) {
135-
final float f = expect.floatValue();
136-
assertTrue(f == converter.convert(s, float.class));
137-
}
138-
else {
139-
final double d = expect.doubleValue();
140-
assertTrue(d == converter.convert(s, double.class));
141-
}
142-
}
143-
// float to number converters
144-
else if (srcType.equals(Float.class)) {
145-
final float f = expect.floatValue();
146-
final double d = expect.doubleValue();
147-
assertTrue(d == converter.convert(f, double.class));
148-
}
149-
else {
150-
// longs and doubles can't be converted to anything beside bigInteger
151-
// and big decimal
152-
}
153-
}
154-
else {
155-
// no prim equivalents for BigInteger and BigDecimal
156-
}
82+
assertEquals(expect, converter.convert(src, ConversionUtils
83+
.getPrimitiveType(destType)));
15784
}
15885

15986
/**

0 commit comments

Comments
 (0)