Skip to content

Commit 93330a9

Browse files
committed
PTService should not be a SciJavaService
PTService has a significant number of sub-interfaces and subclasses, all of which are directly extended by various services through the SciJava software stack (e.g. in ImageJ2). Having PTService as a SciJavaService thus causes all of these implementing classes to get pulled into Contexts created with "SciJavaService.class" - which is supposed to just provide the core services. Subclasses should instead implement the correct scoping interface (e.g. SCIFIOService or ImageJService).
1 parent 19cbedc commit 93330a9

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/main/java/org/scijava/plugin/PTService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
import java.util.List;
3939

40-
import org.scijava.service.SciJavaService;
40+
import org.scijava.service.Service;
4141

4242
/**
4343
* A service for managing a particular sort of {@link SciJavaPlugin}.
@@ -84,7 +84,7 @@
8484
* @see TypedService
8585
* @see WrapperService
8686
*/
87-
public interface PTService<PT extends SciJavaPlugin> extends SciJavaService {
87+
public interface PTService<PT extends SciJavaPlugin> extends Service {
8888

8989
/**
9090
* Gets the service responsible for discovering and managing this service's

0 commit comments

Comments
 (0)