EclipseHelper: use a different tell-tale than ':' for jar: URLs

dscho · dscho · commit 3d2aec61b56c · 2013-12-13T22:58:22.000-06:00
When running the EclipseHelper to index annotations on directories, we
used to look for colons in the path to determine whether it might not
be a plain file. This interferes with those pesky DOS-style paths that
Windows still retains, though.

So just switch to look for a leading slash (which is used in URLs even on
Windows).

Pointed out by Jamion Jenkins.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
diff --git a/src/main/java/org/scijava/annotations/EclipseHelper.java b/src/main/java/org/scijava/annotations/EclipseHelper.java
@@ -134,7 +134,7 @@ private void maybeIndex(final URL url, final ClassLoader loader) {
 			return;
 		}
 		String path = url.getFile();
-		if (path.indexOf(':') >= 0) {
+		if (!path.startsWith("/")) {
 			return;
 		}
 		if (path.endsWith(".jar")) {

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ private void maybeIndex(final URL url, final ClassLoader loader) {`
`134`	`134`	`return;`
`135`	`135`	`}`
`136`	`136`	`String path = url.getFile();`
`137`		`- if (path.indexOf(':') >= 0) {`
	`137`	`+ if (!path.startsWith("/")) {`
`138`	`138`	`return;`
`139`	`139`	`}`
`140`	`140`	`if (path.endsWith(".jar")) {`