Skip to content

Conversation

@gselzer
Copy link
Member

@gselzer gselzer commented Aug 7, 2024

I created this while bumbling around on #258. It has nothing really to do with that PR anymore, but since the work is done why not keep it?

@gselzer gselzer marked this pull request as ready for review August 7, 2024 16:24
Copy link
Member

@ctrueden ctrueden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was/is the behavior without this work in place? I.e. why is the regular RAI type extractor insufficient?

@gselzer
Copy link
Member Author

gselzer commented Aug 8, 2024

What was/is the behavior without this work in place? I.e. why is the regular RAI type extractor insufficient?

There are two reasons the regular RAI type extractor is insufficient:

  • Unfortunately, ExtendedRandomAccessibleInterval does not implement RandomAccessibleInterval - if we had a RandomAccessible type extractor, utilizing getType(), then we likely wouldn't need this for much, practically speaking.
  • In terms of information gained, ERAI has a second type variable that cannot be reified without a dedicated TypeExtractor plugin.

The second would not be fixed by some broader RandomAccessibleTypeExtractor which used getType (which, as an aside, we should totally do once that code is ready)

@gselzer gselzer force-pushed the scijava-ops-image/extended-rai-type branch from 1ea7a19 to 417c72a Compare August 8, 2024 13:57
@ctrueden ctrueden merged commit 0b5d0e1 into main Aug 9, 2024
@ctrueden ctrueden deleted the scijava-ops-image/extended-rai-type branch August 9, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants