Convert double[][] -> Img & other fun stuff #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gselzer
force-pushed
the
scijava-ops-image/double-mat-to-img-converter
branch
4 times, most recently
from
f621a2d to
86384a7
Compare
gselzer
force-pushed
the
scijava-ops-image/double-mat-to-img-converter
branch
from
86384a7 to
472ba4a
Compare
Merged
hinerm
requested changes
Aug 7, 2024
ctrueden
reviewed
Aug 7, 2024
ctrueden
reviewed
Aug 7, 2024
Member
ctrueden
left a comment
ctrueden
left a comment
There was a problem hiding this comment.
Hasty incomplete review, coming your way!
gselzer
force-pushed
the
scijava-ops-image/double-mat-to-img-converter
branch
from
a54425b to
8118fcc
Compare
Member
Author
1/9 = 0 in Java.
I felt like this made it easier to refer back to these converters, instead of by signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is designed to provide developers with an informative walkthrough in expanding SciJava Ops' conversion capabilities via adding new converters.
There's a bunch of leftover cruft that should be removed if others like the general direction of this PR. Notably, I converted the
Purposedocument to ReStructuredText so that I could add a reference label for easy cross-document references.