Skip to content

Replace script-maven-plugin -> maven-antrun-plugin - #243

Merged
gselzer merged 1 commit into
mainfrom
scijava/switch-to-maven-antrun
Jul 15, 2024
Merged

gselzer merged 1 commit into
mainfrom
scijava/switch-to-maven-antrun

Conversation

@gselzer

@gselzer gselzer commented Jul 9, 2024

Copy link
Copy Markdown
Member

This switch makes copying src Ops into target/test-classes/ops.yaml possible with far less code, and solves some local issues I had with the Ruby dependency.

I additionally tested this code within scijava-types, to observe what happens when this code is called in projects without Ops, and the result is that nothing happens, which is what we'd want!

@ctrueden does this solve #229?

@gselzer gselzer added this to the 1.0.1 milestone Jul 9, 2024
@gselzer
gselzer requested a review from ctrueden July 9, 2024 16:48
@gselzer gselzer self-assigned this Jul 9, 2024
@ctrueden

ctrueden commented Jul 9, 2024

Copy link
Copy Markdown
Member

@ctrueden does this solve #229?

I reverted 5da8173 and did a full build, which succeeded. But IIRC it was my Linux desktop at home that exhibited the problem, so I'll have to repeat that procedure later today while at home to know for sure.

@ctrueden ctrueden self-assigned this Jul 9, 2024
@ctrueden
ctrueden force-pushed the scijava/switch-to-maven-antrun branch from e8162fb to 7300878 Compare July 10, 2024 00:18
@ctrueden

Copy link
Copy Markdown
Member

The exception described in #228 still occurs on the affected system:

java.lang.IllegalStateException: Task OpEnvironment: Discovering Ops has subtasks that did not complete!

I do not see any problems with the ops.yaml files. But I also tried restoring the Progress reporting of Op discovery on the latest main branch, and was unable to trigger the YAML problems that way either. In other words: I cannot reproduce the issue of mangled ops.yaml files described by #229, even still using the script-maven-plugin and Ruby script. But either way, #228 is still an issue, for reasons I don't fully understand.

I don't think it's a blocker to merge this PR. For now, I force-pushed away my revert of the Progress reporting again. Some day, I'll have to dig more on #228 using the affected machine.

@gselzer
gselzer merged commit a991acf into main Jul 15, 2024
@gselzer
gselzer deleted the scijava/switch-to-maven-antrun branch July 15, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants