Repository navigation
Replace script-maven-plugin -> maven-antrun-plugin - #243
Merged
Merged
Conversation
Member
ctrueden
force-pushed
the
scijava/switch-to-maven-antrun
branch
from
July 10, 2024 00:18
e8162fb to
7300878
Compare
Member
|
The exception described in #228 still occurs on the affected system: I do not see any problems with the I don't think it's a blocker to merge this PR. For now, I force-pushed away my revert of the Progress reporting again. Some day, I'll have to dig more on #228 using the affected machine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switch makes copying
srcOps intotarget/test-classes/ops.yamlpossible with far less code, and solves some local issues I had with the Ruby dependency.I additionally tested this code within
scijava-types, to observe what happens when this code is called in projects without Ops, and the result is that nothing happens, which is what we'd want!@ctrueden does this solve #229?