Add ReducedInfoTreeGenerator #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gselzer
force-pushed
the
scijava-ops-engine/add-reduced-info-tree-generator
branch
3 times, most recently
from
74ca2d3 to
64a3e0b
Compare
gselzer
force-pushed
the
scijava-ops-engine/add-reduced-info-tree-generator
branch
from
64a3e0b to
4ece27d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
InfoTreeGeneratorable to convert Reduced Op (i.e. Ops with some optional parameters omitted) signatures back into Reduced Ops.Notably, this PR works upon assumptions, described within the javadoc ofReducedInfoTreeGenerator. I would appreciate on someone else (@hinerm?) signing off on them before merge.I held off on creating a PR for this because I wanted to think more about if there was an easy "more correct" way to enable the desired behavior, but I do not believe this would be easily accomplished.EDIT: I found a "better way" of doing things, that additionally fixes package cycles!