Restrict Ops to single output #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrueden
reviewed
Jun 14, 2019
Member
ctrueden
left a comment
ctrueden
left a comment
There was a problem hiding this comment.
Nice! Just one small thing I noticed.
| i++; | ||
| } | ||
| final Type outputType = candidate.getRef().getOutType(); | ||
| if (Objects.equal(outputType, OpUtils.outputType(candidate))) |
Member
There was a problem hiding this comment.
Do you need the Guava Objects.equal here, rather than the standard Java library's Objects?
Member
Author
There was a problem hiding this comment.
Woops, nope, that probably was an auto-import fail. Good catch - thanks!
Edit: or rather a misstyped equal vs equals. Fixed it.
This commit removes the support for secondary Op outputs. Both OpRef and OpInfo only specify single outputs from now on. Op matching and transformation are adapted accordingly. Also, validation is added to enforce this new constraint during Op discovery.
wiedenm
force-pushed
the
single-op-output
branch
from
3fe607a to
c107500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the support for secondary Op outputs. Both OpRef and OpInfo only specify single outputs from now on. Op matching and transformation are adapted accordingly. Also, validation is added to enforce this new constraint during Op discovery and Op dependency resolution.